Total Hits - 1405 Total Votes - 0 votes Vote Up - 0 votes Vote Down - 0 votes Domain - www.instanceofjava.com Category - JAVA/Core JAVA Submitted By - saidesh Submitted on - 2018-02-08 00:11:35 Description If you have a numpy array to begin with rather than a list (since you mention a "real numpy array" in your post) you could use re.sub on the string representation of the array: print(re.sub('[\[\]]', '', np.array_str(a))) Again, this is assuming your array a was a numpy array at some point. But you're right, it was a regex issue. How unusual is a Vice President presiding over their own replacement in the Senate? the most simple solution for removing the brackets is, 1.convert the arraylist into string with.toString () method. I found stock certificates for Disney and Sony that were given to me in 2011. (where strLen is the length of string after conversion from arraylist). New to Ruby here. Young Adult Fantasy about children living with an elderly woman and learning magic related to their skills. You would need to either first coerce each integer in the list to a string type (not recommended, very inefficient), or you could create your list as a list of strings containing numbers: num = ['1', '2', '3'].The string.join() method is a string method, it takes different strings and basically concatenates them for you using the sort of spacing you want. The array contains slashes and gets replaced one-by-one when the correct letter is guessed. The syntax for an array is a set of square brackets. How can I cut 4x4 posts that are already mounted? To learn more, see our tips on writing great answers. The array contains slashes and gets replaced one by one when the correct letter is guessed. dot net perls. Arrays are ordered collections of objects. array.join(", ") share | improve this answer. your coworkers to find and share information. The to_s method is used to create a string representation of an array. Also eigentlich ähnlich dem, was wir aus anderen dynamischen Programmiersprachen wie Perl, Python und PHP kennen. Hey everyone, Newb question: I want to read the user input an array of numbers. How should I refer to a professor as a undergrad TA? For easy processing, we can store these strings in a string array. site design / logo © 2021 Stack Exchange Inc; user contributions licensed under cc by-sa. Examples: a[b][c] x[y][z][] I'm trying to produce multidimensional arrays from it. We can convert array to string by iterating array and capturing each element from an array and append to StringBuilder/StringBuffer so that final output will be string without brackets. How do I read / convert an InputStream into a String in Java? Der Index beginnt standardmäßig bei 0. The same two lines in ruby 1.9 produce (not wanted). This print the array as is without brackets. A string is a sequence of one or more characters that may consist of letters, numbers, or symbols.. Strings in Ruby are objects, and unlike other languages, strings are mutable, which means they can be changed in place instead of creating new strings.. You’ll use strings in almost every program you write. This has the advantage of working on matrices as well. For loop in Ruby (iterating over array elements) each; for; Prev Next . Convert Array to String array.to_s. How can a supermassive black hole be 13 billion years old? Arrays can contain all kinds of things: ["A string… a.b.c = value. And if you need to do this for more than one fruit the best way is to transform the array and the use the each statement. Join Stack Overflow to learn, share knowledge, and build your career. Why did Trump rescind his executive order that barred former White House employees from lobbying the government? Arrays can contain all Ruby data types. In order to remove all square brackets and their contents from a string, I used the gsub function in ruby like this: "string".gsub(/\[. What is the standard practice for animating motion -- move character or not move character? Is this possible? Note that any type of variables can be stored in an array, including variables of different types in the same array. Mobile friendly way for explanation why button is disabled. Flattening takes out stacked arrays and creates one level, so if you had [1,2,[3,[4,5,6]]] and called flatten on it, you would get [1,2,3,4,5,6]. Why does vocal harmony 3rd interval up sound better than 3rd interval down? I think your issue isn't related to the version of Ruby. My question is about how to convert array elements to string in ruby 1.9 without getting the brackets and quotation marks. I am attempting to put an if else statement in an array to send a string if a certain modulus == 0. for the life of me i can't find it anywhere. Stack Overflow for Teams is a private, secure spot for you and "programming" # true In addition, Ruby 2.5 introduced the delete_prefix & delete_suffix methods, which may be useful to you. 4.8 Arrays Arrays in Ruby haben Indizes vom Typ Integer. Given an array of strings, you could go over every string & make every character UPPERCASE.. Or if you have a list of User objects…. Here’s an example: string = "bacon is expensive" string.delete_suffix(" is expensive") # "bacon" Convert a String to An Array of … 3.Hurraaah..the result string is your string with removed brackets. Join Stack Overflow to learn, share knowledge, and build your career. Let’s see an example: Notice that sort will return a new arraywith the results. My question is about how to convert array elements to string in ruby 1.9 without getting the brackets and quotation marks. the most simple solution for removing the brackets is, 1.convert the arraylist into string with.toString () method. String objects may be created using ::new or as literals.. Because of aliasing issues, users of strings should be aware of the methods that modify the contents of a String object. a = [] This creates a legitimate array, although it’s not very useful if it doesn’t have anything in it. I thought I could produce code like, /home/test/example.rb:450:in `+': can't convert Array into String (TypeError), My current solution is to remove brackets and quotation marks with a temporary string, like. Not that this means a lot other than instead of expecting array.to_s to return a string it's actually returning array.inspect which, based on the name of the method, isn't really what you are looking for. In this mode, we save some typing. Use interpolation instead of concatenation: It's more idiomatic, more efficient, requires less typing and automatically calls to_s for you. Why is using “for…in” for array iteration a bad idea? Convert String to Number in Ruby; Count digits in Ruby; Hello World using CGI in Ruby; Ruby ENV - access the environment variables ; How to write to file in Ruby; Logical operators in Ruby (and, or, not), (&&, ||, !) This print the array as is without brackets. Example: arr = ['a', 'b', 'c'] arr.join # "abc" It’s also possible to pass an argument to join, this argument is the character separator. How to kill an alien with a decentralized organ system? In the main algorithm, the string of symbols needs to be separated, or split, into an array to easily implement LIFO using existing Ruby array methods. Why do small merchants charge an extra 30 cents for small amounts paid by credit card? Returns a new Array. I am using the usual .toString() function of the ArrayList class and my output is formatted like: [ a, n, d, r, o, i, d ]. Sort array of objects by string property value. We do not use the commas and double quotes. Convert Array to String array.to_s. Is it kidnapping if I steal a car that happens to have a baby in it? UK - Can I buy things for myself through my company? Introduction. Iain is correct though, without seeing the regex, we can't suss out the root cause. Ruby 1.9.3 doc#Array#slice Please use the following link to visit the site. In the first quarter we sold ["2"] ["Apple"] (s). @Iain but what does that get me? If you would like to take an array of strings & join these strings into a big string you can use the join method. Thanks, ~sphoenixee~ To learn more, see our tips on writing great answers. For example, 3 is a numeric literal and "Ruby" is a string literal. how to remove square brackets from string in java java convert array to string without brackets example program. *?\]/, "") This removes anything contained within those brackets. (where strLen is the length of string after conversion from arraylist). Asking for help, clarification, or responding to other answers. It is also more robust than doing array[0][0], because, if you had more than two arrays nested in the first element, you would run into the same issue. Why do small merchants charge an extra 30 cents for small amounts paid by credit card? Asking for help, clarification, or responding to other answers. Is it usual to make significant geo-political statements immediately before leaving office? Convert an Array to a String. Thank you! How it is possible that the MIG 21 to have full rudder to the left but the nose wheel move freely to the right then straight or to the left? Thanks for contributing an answer to Stack Overflow! 1.9.X returns: You need to show us the regex to really fix this properly, but this will do it: This doesn't necessarily fix why you are getting a doubled-up array, but you can flatten it and then call the first element like this. What Is a String… Was memory corruption a common problem in large programs written in assembly language? Working With Ruby Strings, Arrays & Hashes This is lesson #3 of the Complete Ruby Tutorial For Beginners series. Why is it bad style to `rescue Exception => e` in Ruby? A String object holds and manipulates an arbitrary sequence of bytes, typically representing characters.String objects may be created using String::new or as literals.. Because of aliasing issues, users of strings should be aware of the methods that modify the contents of a String object. I am sure someone will find it ridiculously simple. For example: user inputs [5,3,46,6,5] gets.chomp converts this to a string “[5,3,46,6,5]” I want [5,3,46,6,5] (the arrray, not the string) Any help would be greatly appreciated. For the regex gurus, split by -> and avoiding bracket/quotes contents, Regex : replace quotes except inside curly brackets. An array literal is a list of variables enclosed in square brackets and separated by commas, like [ 1, 2, 3 ]. See the syntax for initialization and iteration. answered Jan 24 '13 at 18:05. It’s also possible to sort “in-place” using the sort!method. With no block and a single Integer argument size, returns a new Array of the given size whose elements are all nil: The elements of the array are put between square brackets and separated by commas. Lets see an example java program to convert array to string by removing brackets. add a comment | 12. to_s is just an alias to inspect for the Array class. (where strLen is the length of string after conversion from arraylist). the most simple solution for removing the brackets is, 1.convert the arraylist into string with.toString () method. 2.use String.substring (1,strLen-1). Arrays can have anything in them (even other arrays!). We respect your decision to block adverts and trackers while browsing the Internet. An array literal is a list of variables enclosed in square brackets and separated by commas, like [ 1, 2, 3 ]. To subscribe to this RSS feed, copy and paste this URL into your RSS reader. In this part of the Ruby tutorial we will cover arrays. Thanks for contributing an answer to Stack Overflow! I have an array like so: ["data","data2"] What would be the most Ruby-like way to convert this into a string with brackets included: "['data','data2']" Thanks => "In the first quarter we sold 2 Apple(s)." At its most basic, and empty array can be created just by assigning an empty set of square brackets to a variable. Why the brackets and quotes? With a string array, we can handle each word separately (with no parsing steps). In Ruby the C-like for-loop is not in use. Merge Two Paragraphs with Removing Duplicated Lines. string = "ruby programming" string.end_with? rev 2021.1.21.38376, Stack Overflow works best with JavaScript enabled, Where developers & technologists share private knowledge with coworkers, Programming & related technical career opportunities, Recruit tech talent & build your employer brand, Reach developers & technologists worldwide. How to add ssh keys to a specific user in linux? It takes all elements from the inner arrays and creates a new one, without any inner arrays. 2.use String.substring (1,strLen-1). How should I refer to a professor as a undergrad TA? Making statements based on opinion; back them up with references or personal experience. Ruby makes it very easy to create an array. RS-25E cost estimate but sentence confusing (approximately: help; maybe)? You'll notice that the above array has strings, an integer, and a float. Converting array to string and string should not contain any brackets. myArray = ["One.","_1_?! How to check whether a string contains a substring in JavaScript? Consider a book. Array items are not limited to numbers and strings. Who decides how a historic piece is adjusted (if at all) for modern instruments? String array. new ([: foo, 'bar', 2]) a. class # => Array a # => [:foo, "bar", 2]. Ruby String Array ExamplesUse string Arrays. This means that the original array will changeinstead of creating a new one, which can be good for performance. A String object holds and manipulates an arbitrary sequence of bytes, typically representing characters. Ruby-Strings sind dynamisch, veränderbar und flexibel. a = Array. Strings let you display and communicate with your users using text. How do I get just the text, without the quotes and brackets? The most basic form of sorting is provided by the Ruby sort method, which is defined by the Enumerable module. (get-content C:\Services.csv) -match 'Server01' | foreach {'ServerName={0};Status={1}' -f $_.split(',')} Ruby does this behind the scenes when you use string interpolation to print an array to the screen. 3.Hurraaah..the result string is your string with removed brackets. Can a Familiar allow you to avoid verbal and somatic components? ruby 1.9 how to convert array to string without brackets, Episode 306: Gaming PCs to heat your home, oceans to cool your data centers, Getting the string from a rails pluck to display n. How do I check if an array includes a value in JavaScript? a = *(1..100) a.each { |i| puts "three" if i % 3 == 0 elsif puts "five" if i … This can be useful for iterating over the string and was used in pre-1.9.x and pre-1.8.7 (which backported a number of features from 1.9.x) to iterate over characters in a string without worrying about breaking up multi-byte Unicode characters . How do I print an array without the brackets and commas? How do I convert a String to an int in Java? We respect your decision to block adverts and trackers while browsing the Internet. This will create a type mismatch if we try to remove the array square brackets because as per the request format, your data attribute is expecting a single object but in … How to convert array to string without brackets in java\r\nHow to convert array to string without brackets in java\r\nHow to convert array to string without brackets in java\r\n Source Website. How to replace all occurrences of a string? x.y.z = [value] (value is an array because of []) anyway i have some ideas on how to do that but first I need to split the string into an array … Sorry Leif, but your comment does not help me. Typically, methods with names ending in “!'' Really?!","Yes!"]. Put that in your question; that's illegible. I didn't post an answer because I can't reproduce your issue under 1.9 - hence a comment. By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy. With no block and no arguments, returns a new empty Array object. I didn't think you'd appreciate an answer of "works for me!". Example: arr = ['a', 'b', 'c'] arr.join("-") # "a-b-c" How do i print an array without the brackets and commas? 2.use String.substring (1,strLen-1). site design / logo © 2021 Stack Exchange Inc; user contributions licensed under cc by-sa. That did it. Regular expression to extract text between square brackets. Is there a bias against mention your name on presentation slides? The main use for map is to TRANSFORM data. For example, 3 is a numeric literal and "Ruby" is a string literal. the string is the name of some input fields. Why did Churchill become the PM of Britain during WWII instead of Lord Halifax? How to add ssh keys to a specific user in linux? It contains well written, well thought and well explained computer science and programming articles, quizzes and practice/competitive programming/company interview Questions. If there are multiple elements to the array: What "to_s" on an Array returns, depends on the version of Ruby you are using as mentioned above. An array of sorted elements! This is the classic array creation. However, what would be a more elegant "ruby" way how to do that? This is the java programming blog on "OOPS Concepts" , servlets jsp freshers and 1, 2,3 years expirieance java interview questions … Map is a Ruby method that you can use with Arrays, Hashes & Ranges. By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy. modify their receiver, while those without a “!'' What am I missing? Synopsis How to convert array to string without brackets in java Statistics. Making statements based on opinion; back them up with references or personal experience. I've got an array (DB extract), from which I want to use to create a periodic report. Which is better: "Interaction of x with y" or "Interaction between x and y", My friend says that the story of my novel sounds too similar to Harry Potter. animals = %w( donkey dog cat dolphin eagle ) The code line creates a string array with five elements. After reading in the documentation How can ATC distinguish planes that are stacked up in a holding pattern from each other? An Array is created by separating values by commas, and enclosing this list with square brackets, like so: [1, 2, 3] This is a simple Array that holds three numbers. If you just want to separate the items and print a list without the brackets and single quotes, then you don’t need to specify the value of sep because it has a default value of whitespace. Erick Eduardo Garcia Erick Eduardo Garcia. With no block and a single Array argument array, returns a new Array formed from array:. To subscribe to this RSS feed, copy and paste this URL into your RSS reader. to_s is just an alias to inspect for the Array class. irb :002 > array = [1, 'Bob', 4.33, 'another string'] We'd like to find the first element of the array… 967 10 10 silver badges 15 15 bronze badges. For example:. * written in front of apples causes apples to be unpacked in items and converted into a string, then these items are combined with value which is specified in the sep keyword. 3.Hurraaah..the result string is your string with removed brackets. How to kill an alien with a decentralized organ system? This essentially turns the string into an array of equal length containing only one-character strings, one for each character in the string. Now we need to save this array in a variable so we can play with it. Would having only 3 fingers/toes on their hands/feet effect a humanoid species negatively? Wenn Sie ein neues Array erzeugen, können Sie seine Größe über einen Parameter angeben, müssen das aber nicht, denn Arrays passen ihre Grösse dynamisch der zu speichernden Datenmenge an. rev 2021.1.21.38376, Stack Overflow works best with JavaScript enabled, Where developers & technologists share private knowledge with coworkers, Programming & related technical career opportunities, Recruit tech talent & build your employer brand, Reach developers & technologists worldwide, Wed Oct 23 18:16:46#8>ruby -v ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-darwin12.5.0] Wed Oct 23 18:16:51#9>irb irb(main):001:0> myArray = ["Apple", "Pear", "Banana", "2", "15", "12"] => ["Apple", "Pear", "Banana", "2", "15", "12"] irb(main):002:0> reportStr = "In the first quarter we sold " + myArray[3].to_s + " " + myArray[0].to_s + "(s)." Episode 306: Gaming PCs to heat your home, oceans to cool your data centers, RegEx match open tags except XHTML self-contained tags, Getting the string from a rails pluck to display n. With arrays, why is it the case that a[5] == 5[a]? I am using the usual .toString() function of the ArrayList class and my output is formatted like: [ a, n, d, r, o, i, d ]. Why does the US President use a new pen for each order? Stack Overflow for Teams is a private, secure spot for you and Can a Familiar allow you to avoid verbal and somatic components? Note that any type of variables can be stored in an array, including variables of different types in the same array. Creating Arrays. How do I make the first letter of a string uppercase in JavaScript? You could convert them into a list of their corresponding email addresses, phone number, or any other attribute defined on the User class. irb(main):003:0> puts reportStr In the first quarter we sold 2 Apple(s). I want it to simply print out the array as a single String. your coworkers to find and share information. You'll learn about different ways to work with & store data in Ruby. If not, then I want to convert the string input (from gets) into an array. How can I remove a specific item from an array? A Computer Science portal for geeks. How were scientific plots made in the 1960s? How do countries justify their missile programs? It contains many words—thousands of strings that have meaning. If it is an opener , … Do US presidential pardons include the cancellation of financial punishments? I want it to simply print out the array as a single string. irb :001 > a = [1, 2, 3] => [1, 2, 3] irb :002 > "It's as easy as #{a}" => "It's as easy as [1, 2, 3]" An Array is created by listing objects, separated by commas, and enclosed by square brackets. In java Statistics on opinion ; ruby array to string without brackets them up with references or personal experience I convert a string in 1.9! To simply print out the root cause n't related to the screen ähnlich dem was. Example java program to convert array to string by removing brackets better than 3rd up. Syntax for an array inspect for the array contains slashes and gets one... Ca n't suss out the root cause but your comment does not help me site design / logo 2021. Can handle each word separately ( with no block and no arguments, a... Be a more elegant `` Ruby '' is a string contains a substring JavaScript! My question is about how to add ssh keys to a professor as a undergrad TA type of can! Rescind his executive order that barred former White House employees from lobbying the?! And your coworkers to find and share information animals = % w donkey. And avoiding bracket/quotes contents, regex: replace quotes except inside curly brackets can! 2 '' ] ( s ). written in assembly language effect a humanoid species?! Answer of `` works for me! `` ] split by - > and avoiding contents! ’ s see an example: Notice that sort will return a new empty can! ; maybe ) to print an array to string in Ruby haben Indizes Typ!: Notice that sort will return a new array formed from array.. The site with removed brackets living with an elderly woman and learning magic related to version... My question is about how to convert array to string in Ruby 1.9 without getting the and. Of an array ( DB extract ), from which I want to read the input! Single array argument array, including variables of different types in the first letter of a string array to square... 1.Convert the arraylist into string with.toString ( ) method \ ] /, `` ) |! Presentation slides can have anything in them ( even other arrays! ). and. In them ( even other arrays! ). to an int in java java convert array string! Do that answer because I ca n't suss out the root cause requires! '' ) this removes anything contained within those brackets a periodic report array is set! Store these strings into a big string you can use the following link to visit site... Not move character or not move character a numeric literal and `` Ruby '' is a private, secure for., was wir aus anderen dynamischen Programmiersprachen wie Perl, Python und kennen! A professor as a undergrad TA it contains well written, well thought and well computer... Unusual is a string in Ruby 1.9 produce ( not wanted ). the result string is string! Related to the screen Apple ( s ). an ruby array to string without brackets to string without brackets in java Statistics supermassive hole! Humanoid species negatively remove square brackets and separated by commas ; Prev Next Ruby haben vom! ``, `` ) share | improve this answer avoid verbal and somatic components the US President a... The C-like for-loop is not in use convert an InputStream into a string literal an into... With five elements share | improve this answer the string input ( from gets into... It very easy to create an array decision to block adverts and while.: replace quotes except inside curly brackets former White House employees from the... From arraylist ). arrays arrays in Ruby haben Indizes vom Typ Integer and programming,... Answer ”, you agree to our terms of service, privacy policy and cookie policy way how to the... Slashes and gets replaced one by one when the correct letter is guessed, or responding to other answers simply. On matrices as well be useful to you steal a car that happens to have a baby in it me. Brackets to a specific user in linux sentence confusing ( approximately: help ; maybe ) the. For Disney and ruby array to string without brackets that were given to me in 2011 ridiculously simple take an array, a... I ca n't reproduce your issue is n't related to the screen ] /, `` '' ) removes! Is provided by the Enumerable module use string interpolation to print an array of that! A periodic report this RSS feed, copy and paste this URL into your RSS reader % w ( dog. Bracket/Quotes contents, regex: replace quotes except inside curly brackets living with an elderly woman and learning related! Quizzes and practice/competitive programming/company interview Questions of `` works for me! ]! Is the standard practice for animating motion -- move character Programmiersprachen wie Perl, Python und PHP kennen a... The join method undergrad TA science and programming articles, quizzes and practice/competitive programming/company Questions. For an array is created by listing objects, separated by commas array be... Simple solution for removing the brackets and commas do small merchants charge an extra 30 cents for small amounts by! From array: the length of string after conversion from arraylist ). a... Approximately: help ; maybe ) by - > and avoiding bracket/quotes contents, regex: replace quotes except curly... Is an opener, … how do I make the first letter of a string in Ruby haben vom. You 're right, it was a regex issue over their own replacement in the quarter! Answer of `` works for me! `` 3 fingers/toes on their hands/feet effect humanoid! Share | improve this answer gets ) into an array be useful to you --... Build your career the screen learn more, see our tips on writing great.!, and build your career synopsis how to convert array to string without brackets in java java convert array to. Solution for removing the brackets and quotation marks by assigning an empty set of square brackets from in. Is disabled out the array contains slashes and gets replaced ruby array to string without brackets when the correct letter is guessed `... String representation of an array of numbers think your issue under 1.9 - hence a comment agree to terms... At its most basic, and build your career of variables can be stored in array. One when the correct letter is guessed 1.9 produce ( not wanted ). for you and your coworkers find! Delete_Suffix methods, which can be good for performance decides how a piece. Ruby 1.9 produce ( not wanted ). split by - > and avoiding contents! May be useful to you of service, privacy policy and cookie policy string you can use following., split by - > and avoiding bracket/quotes contents, regex: replace except! Kidnapping if I steal a car that happens to have a baby in it ( DB extract ) from... To a variable so we can handle each word separately ( with no block and no arguments returns... Irb ( main ):003:0 > puts reportStr in the first letter a... An InputStream into a string to an int in java by listing,... From the inner arrays, what would be a more elegant `` Ruby '' way how to check whether string... And somatic components children living with an elderly woman and learning magic related to their skills many of! To remove square brackets what would be a more elegant `` Ruby '' way how to kill alien. Possible to sort “ in-place ” using the sort! method I remove specific. Objects, separated by commas and `` Ruby '' is a private, secure for. Order that barred former White House employees from lobbying the government in “! '', '' Yes! ]... Methods with names ending in “! '', '' Yes! `` Disney and Sony that were given me! Create an array cat dolphin eagle ) the code line creates a string contains a substring in JavaScript you. See an example java program to convert array elements ) each ; for ; Prev Next knowledge... Array formed from array: to TRANSFORM data got an array is a string array >! With a decentralized organ system silver badges 15 15 bronze badges appreciate an answer of `` works for me ``! Calls ruby array to string without brackets for you only 3 fingers/toes on their hands/feet effect a species! The screen privacy policy and cookie policy cookie policy the result string is string! Pardons include the cancellation of financial punishments cut 4x4 posts that are mounted. Humanoid species negatively the inner arrays elegant `` Ruby '' is a Vice President over. Item from an array, we can play with it answer of `` works for me ``! Curly brackets do not use the join method ), from which want... In it 15 15 bronze badges C-like for-loop is not in use java Statistics you! Getting the brackets and quotation marks formed from array: including variables of different types in the same array wir... Maybe ) with names ending in “! '', '' _1_?! '' ''... Create a string contains a substring in JavaScript US presidential pardons include the cancellation of financial punishments this... 10 10 silver badges 15 15 bronze badges store data in Ruby rescue Exception = > `` in same! The elements of the array are put between square brackets from string in java and. Why button is disabled any type of variables can be stored in an array to without! Why button is disabled for an array animals = % w ( donkey cat... Presentation slides n't Post an answer of `` works for me! `` this answer of variables can good. Formed from array: of working on matrices as well during WWII instead of Lord Halifax decides how historic!